Use TypeId for system registration #3

2025-09-10T10:21:37Z

reo6 commented

2025-09-10 10:21:37 +00:00

(Migrated from github.com)

Summary

Replace string-based IDs with TypeId for engine and rendering systems
Add generic add::<System>() APIs and remove string constants
Update engine, platform, and game to use new system registration flow

Testing

cargo test

https://chatgpt.com/codex/tasks/task_e_68c0b1048e8c832f9e055fab11383c3e

## Summary - Replace string-based IDs with `TypeId` for engine and rendering systems - Add generic `add::<System>()` APIs and remove string constants - Update engine, platform, and game to use new system registration flow ## Testing - `cargo test` ------ https://chatgpt.com/codex/tasks/task_e_68c0b1048e8c832f9e055fab11383c3e

👍 1

reo6 (Migrated from github.com) reviewed 2025-09-10 12:12:35 +00:00

engine/src/system.rs

					
				@ -34,3 +34,2 @@

				    pub fn add_system(&mut self, id: SystemID, system: Box<dyn System>) {

				        self.systems.insert(id, system);

				    pub fn add<S: System + Default + 'static>(&mut self) {

reo6 (Migrated from github.com) commented

2025-09-10 12:12:35 +00:00

@codex Please revert this.

chatgpt-codex-connector[bot] (Migrated from github.com) reviewed 2025-09-10 12:17:00 +00:00

engine/src/system.rs

					
				@ -34,3 +34,2 @@

				    pub fn add_system(&mut self, id: SystemID, system: Box<dyn System>) {

				        self.systems.insert(id, system);

				    pub fn add<S: System + Default + 'static>(&mut self) {

chatgpt-codex-connector[bot] (Migrated from github.com) commented

2025-09-10 12:17:00 +00:00

Summary

Restored System::update to use the ctx parameter name instead of an underscore-prefixed placeholder, preserving its visibility to implementers engine/src/system.rsL20-L21

Testing

✅ cargo test

Notes

View task →

### Summary - Restored `System::update` to use the `ctx` parameter name instead of an underscore-prefixed placeholder, preserving its visibility to implementers [engine/src/system.rsL20-L21](https://github.com/reo6/raidillon/blob/75fd59a5049f557564029f98e5fd8a85be83ac26/engine/src/system.rs#L20-L21) ### Testing - ✅ `cargo test` ### Notes [View task →](https://chatgpt.com/codex/tasks/task_e_68c16b3d6608832fb8492920e637df70)

Sign in to join this conversation.

No reviewers